Skip to content

Commit

Permalink
[release/2.3] pin sympy==1.12.1 and skip pytorch-nightly installation… (
Browse files Browse the repository at this point in the history
#1529)

This PR pins sympy==1.12.1 in the .ci/docker/requirements-ci.txt file
Also it skips pytorch-nightly installation in docker images

Installation of pytorch-nightly is needed to prefetch mobilenet_v2 avd
v3 models for some tests.
Came from

85bd6bc
Models are downloaded on first use to the folder /root/.cache/torch/hub
But pytorch-nightly installation also overrides
.ci/docker/requirements-ci.txt settings and upgrades some of python
packages (sympy from 1.12.0 to 1.13.0) which causes several
'dynamic_shapes' tests to fail
Skip prefetching models affects these tests without any errors (but
**internet access required**):

- python test/mobile/model_test/gen_test_model.py mobilenet_v2
- python test/quantization/eager/test_numeric_suite_eager.py -k
test_mobilenet_v3

Issue ROCm/frameworks-internal#8772

Also, in case of some issues these models can be prefetched after
pytorch building and before testing

(cherry picked from commit b92b34d)
  • Loading branch information
dnikolaev-amd authored Aug 9, 2024
1 parent f920cd9 commit 324f622
Show file tree
Hide file tree
Showing 2 changed files with 20 additions and 0 deletions.
14 changes: 14 additions & 0 deletions .ci/docker/common/cache_vision_models.sh
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,20 @@

set -ex

# Skip pytorch-nightly installation in docker images
# Installation of pytorch-nightly is needed to prefetch mobilenet_v2 avd v3 models for some tests.
# Came from https://github.com/ROCm/pytorch/commit/85bd6bc0105162293fa0bbfb7b661f85ec67f85a
# Models are downloaded on first use to the folder /root/.cache/torch/hub
# But pytorch-nightly installation also overrides .ci/docker/requirements-ci.txt settings
# and upgrades some of python packages (sympy from 1.12.0 to 1.13.0)
# which causes several 'dynamic_shapes' tests to fail
# Skip prefetching models affects these tests without any errors:
# python test/mobile/model_test/gen_test_model.py mobilenet_v2
# python test/quantization/eager/test_numeric_suite_eager.py -k test_mobilenet_v3
# Issue https://github.com/ROCm/frameworks-internal/issues/8772
echo "Skip torch-nightly installation"
exit 0

source "$(dirname "${BASH_SOURCE[0]}")/common_utils.sh"

# Cache the test models at ~/.cache/torch/hub/
Expand Down
6 changes: 6 additions & 0 deletions .ci/docker/requirements-ci.txt
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,12 @@ click==8.1.7
#Pinned versions: 8.1.7
#test that import:

sympy==1.12.1
#Description: Python library for symbolic mathematics
# installed before coremltools to avoid installation of greater sympy version
#Pinned versions: 1.12.1
#test that import:

coremltools==5.0b5 ; python_version < "3.12"
#Description: Apple framework for ML integration
#Pinned versions: 5.0b5
Expand Down

0 comments on commit 324f622

Please sign in to comment.