Add Compilation Flag for enabling/disabling clipping, and tune number of blocks for mscclpp allreduce8 #1607
+74
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isaki001
requested review from
wenkaidu,
gilbertlee-amd,
akolliasAMD,
PedramAlizadeh,
nusislam,
nileshnegi,
KawtharShafie,
AtlantaPepsi,
mberenjk,
corey-derochie-amd,
mustafabar,
thananon,
JhaShweta1,
BertanDogancay,
rahulvaidya20,
jee7s,
PJAvinash,
AbandiGa,
Nikhil-Nunna and
haripriya-amd
as code owners
nusislam
requested changes
Mar 18, 2025
nusislam
approved these changes
Mar 19, 2025
nileshnegi
reviewed
Mar 24, 2025
|
@nusislam I haven't merged yet since I have added a few commits since your approval. Please let me know if there are any more reviews |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Do not mention proprietary info or link to internal work items in this PR.
Work item: "Internal", or link to GitHub issue (if applicable).
What were the changes?
Added performance optmization in mscclpp by tuning the number of blocks and disabling clipping by default.
Why were the changes made?
observed significant regression between current mscclpp commit in rccl, and prior mscclpp commit.
How was the outcome achieved?
Compilation flag that is set by default to false, prevents clipping routine from wrapping each addition. Additionally, the number of blocks in allreduce8 were increased from 512 to 1024.
Additional Documentation:
Disabling clipping has impact on correctness but may be necessary for particular workloads.
Approval Checklist
Do not approve until these items are satisfied.