Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CMake documentation builds #471

Closed
wants to merge 6 commits into from
Closed

CMake documentation builds #471

wants to merge 6 commits into from

Conversation

saadrahim
Copy link
Member

@saadrahim saadrahim commented Sep 12, 2023 •
edited
Loading

This PR enables

mkdir build
cd build
cmake ../
make doc

@saadrahim
Copy link
Member Author

@MathiasMagnus please update the instructions?

saadrahim
saadrahim commented Sep 13, 2023
View reviewed changes
README.md
# Build the documentation
cmake --build ./rocPRIM/build --target doc

# For e.g. serve the HTML docs locally
Copy link
Member Author

@saadrahim saadrahim Sep 13, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Example to serve the HTML docs locally

saadrahim
saadrahim commented Sep 13, 2023
View reviewed changes
Copy link
Member Author

@saadrahim saadrahim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor phrasing change requested

@stanleytsang-amd
Copy link
Collaborator

@samjwu @saadrahim is this PR stale or still relevant?

@samjwu samjwu mentioned this pull request Jul 10, 2024
Merged
@samjwu
Copy link
Member

samjwu commented Jul 10, 2024

Updated this and created #583 because I am unable to push to the fork this PR is based on

@samjwu
Copy link
Member

samjwu commented Jul 11, 2024

Merged in #583

@samjwu samjwu closed this Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stanleytsang-amd stanleytsang-amd stanleytsang-amd approved these changes

@samjwu samjwu Awaiting requested review from samjwu

Assignees
No one assigned
Labels
ci:codecoverage
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@saadrahim @stanleytsang-amd @samjwu @MathiasMagnus