Merge branch '371-fix-threefry2x64-and-threefry4x64' into 'develop_st…

…ream' Fix threefry2x64 and threefry4x64 Closes #371 See merge request amd/libraries/rocRAND!343
ROCm · Jul 24, 2024 · d4f972c · d4f972c
2 parents d6a97de + 49add41
commit d4f972c
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -17,8 +17,10 @@ Documentation for rocRAND is available at
 ## (Unreleased) rocRAND-3.1.1 for ROCm 6.2.0
 
 ## Fixes
-  * Fixed " unknown extension ?>" issue in scripts/config-tuning/select_best_config.py 
-    when using python version thats older than 3.11
+
+* Fixed " unknown extension ?>" issue in scripts/config-tuning/select_best_config.py 
+  when using python version thats older than 3.11
+* Fixed low random sequence quality of `ROCRAND_RNG_PSEUDO_THREEFRY2_64_20` and `ROCRAND_RNG_PSEUDO_THREEFRY4_64_20`.
 
 ## (Unreleased) rocRAND-3.1.0 for ROCm 6.2.0
 

diff --git a/library/include/rocrand/rocrand_threefry_common.h b/library/include/rocrand/rocrand_threefry_common.h
@@ -70,7 +70,7 @@ template<>
 __forceinline__ __device__ __host__ unsigned long long
     rotl<unsigned long long>(unsigned long long x, int d)
 {
-    return ((x << d) | (x >> (64 - d) & 63));
+    return (x << (d & 63)) | (x >> ((64 - d) & 63));
 };
 
 template<>