RPP JPEG Compression Distortion HOST #531
Open
+2,571
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
r-abishek
commented
Mar 26, 2025
r-abishek
commented
- Adds JPEG Compression Distortion augmentation for HOST on U8/F32/F16/I8.
- Adds relevant unit/perf/QA tests.
Add inverse DCT function Add ycbCr to RGB conversion Add test suite support
RPP Jpeg Compression distortion Tensor Support
Fix CI failures - JPEG HOST
Jpeg compression distortion - resolved review comments
There was a problem hiding this comment.
Pull Request Overview
This PR adds a JPEG Compression Distortion augmentation for HOST along with corresponding unit, performance, and QA tests.
- Adds a new test mapping for jpeg_compression_distortion in common.py
- Updates the test case range in runImageTests.py to include the new augmentation
Reviewed Changes
Copilot reviewed 5 out of 12 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| utilities/test_suite/common.py | Adds a new test mapping for jpeg_compression_distortion |
| utilities/test_suite/HOST/runImageTests.py | Updates the test case maximum to include the new test case |
Files not reviewed (7)
- api/rppt_tensor_geometric_augmentations.h: Language not supported
- src/include/common/cpu/rpp_cpu_simd_load_store.hpp: Language not supported
- src/include/common/cpu/rpp_cpu_simd_math.hpp: Language not supported
- src/include/tensor/host_tensor_executors.hpp: Language not supported
- src/modules/tensor/rppt_tensor_geometric_augmentations.cpp: Language not supported
- utilities/test_suite/HOST/Tensor_image_host.cpp: Language not supported
- utilities/test_suite/rpp_test_suite_image.h: Language not supported
Comments suppressed due to low confidence (1)
utilities/test_suite/common.py:95
- The new test mapping for 'jpeg_compression_distortion' only includes 'HOST', unlike other mappings that include both 'HOST' and 'HIP'. Please verify whether the omission of 'HIP' is intentional.
["jpeg_compression_distortion", "HOST"]
rrawther
reviewed
Apr 2, 2025
| * \image html geometric_augmentations_jpeg_compression_distortion_img150x150.png Sample Output | ||
| * \param [in] srcPtr source tensor in HOST memory | ||
| * \param [in] srcGenericDescPtr source tensor descriptor | ||
| * \param [out] dstPtr source tensor in HOST memory |
|
@r-abishek: I can't really view the jpeg_compression_distortion.cpp file or add any comments. Is this files added in this PR? It is wierd |
|
@rrawther Yes, this file is added in this PR, sometimes the github ui needs refresh for larger diffs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.