Creating ROCm whl upon release #259
Conversation
| @@ -1,23 +1,22 @@ | |||
| #!/bin/bash | |||
| set -eux | |||
|
|
|||
| python_executable=python$1 | |||
There was a problem hiding this comment.
Definitely "python_executable=python$1" is a cryptic way to interface the desirable python flavor (not ideal), but why we limit the script to python3 ?
There was a problem hiding this comment.
What other options are there in our ROCm release docker (or anywhere)?
There was a problem hiding this comment.
python2 ? If somebody decides to use python2 at some point (for whatever reason) this code will break.
There was a problem hiding this comment.
This code will not be within the top 1000 things that will break :)
|
|
||
| # Build | ||
| $python_executable setup.py bdist_wheel --dist-dir=dist | ||
| cd gradlib | ||
| $python_executable setup.py bdist_wheel --dist-dir=dist | ||
| cd .. |
There was a problem hiding this comment.
This makes it perfect, doesn't it?
There was a problem hiding this comment.
We'll see if whls will get published this time.
There was a problem hiding this comment.
That was the last time I approved without seeing functionality proof.
Creating ROCm versions of vllm and gradlib whl