Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vectorized rms_norm support for Navi31 #273

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

hyoon1
Copy link

@hyoon1 hyoon1 commented Nov 12, 2024

  • supports vectorized rms_norm_kernel

@maleksan85
Copy link

As per @gshtras we need to merge into develop branch instead of main for now. Please correct.

@maleksan85 maleksan85 requested a review from gshtras November 13, 2024 18:04
@gshtras gshtras changed the base branch from main to develop November 13, 2024 18:12
@hyoon1
Copy link
Author

hyoon1 commented Nov 13, 2024

As per @gshtras we need to merge into develop branch instead of main for now. Please correct.

Updated

Copy link

@maleksan85 maleksan85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

- supports vectorized rms_norm_kernel
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants