Enable CK Attention for Navi31 #285
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hyoon1
commented
Nov 18, 2024
•
hyoon1
commented
- Enables CK Attention for Navi31
- Requires this branch of Flash Attention:
- https://github.com/ROCm/flash-attention/tree/howiejay/navi_support
- Enables CK Attention for Navi31 - Requires this branch of Flash Attention: - https://github.com/ROCm/flash-attention/tree/howiejay/navi_support
gshtras
requested changes
Dec 16, 2024
| from flash_attn import flash_attn_varlen_func # noqa: F401 | ||
| self.attn_func = flash_attn_varlen_func | ||
| if flash_attn_available: | ||
| if current_platform.has_device_capability(110): |
There was a problem hiding this comment.
This check isn't equivalent to is_navi
On Cuda device_capability is meant to increase with each new architecture, and is meant to differentiate by new features support, such as FP8, etc.
On ROCm it is 1st digit of gfx * 10 + 2nd digit, which doesn't mean much, especially for any future architectures.
PR #281 is specific to a particular vision model and does not call the path used in general LLM models. Therefore, it seems difficult to merge. The condition has been simplified to match the depth in the existing code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.