Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable softcap and gemma2 #288

Merged
merged 9 commits into from
Dec 4, 2024
Merged
Changes from 5 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 20 additions & 10 deletions vllm/attention/backends/rocm_flash_attn.py
Original file line number Diff line number Diff line change
Expand Up @@ -218,12 +218,6 @@
max_encoder_seq_len=self.max_encoder_seq_len,
cross_slot_mapping=self.cross_slot_mapping,
cross_block_tables=self.cross_block_tables)
# Batch may be composed of prefill|decodes, adjust query start indices
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this section being removed?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry... this is accident... it has been restored.

# to refer to the start of decodes when the two are split apart.
# E.g. in tokens:[3 prefills|6 decodes], query_start_loc=[3,9] => [0,6].
if self._cached_decode_metadata.query_start_loc is not None:
qs = self._cached_decode_metadata.query_start_loc
self._cached_decode_metadata.query_start_loc = qs - qs[0]
return self._cached_decode_metadata

def advance_step(self,
Expand Down Expand Up @@ -459,10 +453,12 @@
if blocksparse_params is not None:
raise ValueError(
"ROCmFlashAttention does not support blocksparse attention.")
if logits_soft_cap is not None:
raise ValueError(
"ROCmFlashAttention does not support attention logits soft "
"capping.")

if logits_soft_cap is None:
# In flash-attn, setting logits_soft_cap as 0 means no soft cap.
logits_soft_cap = 0
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This effectively enables logits_soft_cap for any model, unconditionally.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

self.logits_soft_cap = logits_soft_cap

self.num_heads = num_heads
self.head_size = head_size
self.scale = float(scale)
Expand All @@ -487,6 +483,14 @@
# NOTE: Allow for switching between Triton and CK. Defaulting to triton.
self.use_triton_flash_attn = envs.VLLM_USE_TRITON_FLASH_ATTN
if self.use_triton_flash_attn:
if logits_soft_cap is not None:
raise ValueError(
"ROCm Triton FlashAttention does not support attention"
"logits soft capping."
" please try using the ROCm CK "
"FA backend instead by setting the env var "
"`VLLM_USE_TRITON_FLASH_ATTN=0`")

from vllm.attention.ops.triton_flash_attention import ( # noqa: F401
triton_attention)
self.attn_func = triton_attention
Expand All @@ -505,12 +509,17 @@
else:
try:
from flash_attn import flash_attn_varlen_func # noqa: F401
self.attn_func = flash_attn_varlen_func

Check failure on line 512 in vllm/attention/backends/rocm_flash_attn.py

View workflow job for this annotation

GitHub Actions / mypy (3.9)

Cannot determine type of "attn_func" [has-type]

Check failure on line 512 in vllm/attention/backends/rocm_flash_attn.py

View workflow job for this annotation

GitHub Actions / mypy (3.10)

Cannot determine type of "attn_func" [has-type]

Check failure on line 512 in vllm/attention/backends/rocm_flash_attn.py

View workflow job for this annotation

GitHub Actions / mypy (3.11)

Cannot determine type of "attn_func" [has-type]

Check failure on line 512 in vllm/attention/backends/rocm_flash_attn.py

View workflow job for this annotation

GitHub Actions / mypy (3.12)

Cannot determine type of "attn_func" [has-type]
logger.debug("Using CK FA in ROCmBackend")
except ModuleNotFoundError:
self.use_naive_attn = True

if self.use_naive_attn:
if logits_soft_cap is not None:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You make sure it's not None in the constructor. So naive flash attention can never be used now

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed. thanks.

raise ValueError(
"ROCm Naive FlashAttention does not support"
"attention logits soft capping.")

self.attn_func = _sdpa_attention
logger.debug("Using naive (SDPA) attention in ROCmBackend")

Expand Down Expand Up @@ -663,7 +672,7 @@
query.dtype,
seq_lens,
make_attn_mask=False) # type: ignore
out, _ = self.attn_func(

Check failure on line 675 in vllm/attention/backends/rocm_flash_attn.py

View workflow job for this annotation

GitHub Actions / mypy (3.9)

Cannot determine type of "attn_func" [has-type]

Check failure on line 675 in vllm/attention/backends/rocm_flash_attn.py

View workflow job for this annotation

GitHub Actions / mypy (3.10)

Cannot determine type of "attn_func" [has-type]

Check failure on line 675 in vllm/attention/backends/rocm_flash_attn.py

View workflow job for this annotation

GitHub Actions / mypy (3.11)

Cannot determine type of "attn_func" [has-type]

Check failure on line 675 in vllm/attention/backends/rocm_flash_attn.py

View workflow job for this annotation

GitHub Actions / mypy (3.12)

Cannot determine type of "attn_func" [has-type]
query,
key,
value,
Expand Down Expand Up @@ -692,7 +701,7 @@
key = key.movedim(0, key.dim() - 2)
value = value.movedim(0, value.dim() - 2)
# sdpa math backend attention
out = self.attn_func(

Check failure on line 704 in vllm/attention/backends/rocm_flash_attn.py

View workflow job for this annotation

GitHub Actions / mypy (3.9)

Cannot determine type of "attn_func" [has-type]

Check failure on line 704 in vllm/attention/backends/rocm_flash_attn.py

View workflow job for this annotation

GitHub Actions / mypy (3.10)

Cannot determine type of "attn_func" [has-type]

Check failure on line 704 in vllm/attention/backends/rocm_flash_attn.py

View workflow job for this annotation

GitHub Actions / mypy (3.11)

Cannot determine type of "attn_func" [has-type]

Check failure on line 704 in vllm/attention/backends/rocm_flash_attn.py

View workflow job for this annotation

GitHub Actions / mypy (3.12)

Cannot determine type of "attn_func" [has-type]
query,
key,
value,
Expand All @@ -705,7 +714,7 @@
attn_masks,
)
else:
out = self.attn_func(

Check failure on line 717 in vllm/attention/backends/rocm_flash_attn.py

View workflow job for this annotation

GitHub Actions / mypy (3.9)

Cannot determine type of "attn_func" [has-type]

Check failure on line 717 in vllm/attention/backends/rocm_flash_attn.py

View workflow job for this annotation

GitHub Actions / mypy (3.10)

Cannot determine type of "attn_func" [has-type]

Check failure on line 717 in vllm/attention/backends/rocm_flash_attn.py

View workflow job for this annotation

GitHub Actions / mypy (3.11)

Cannot determine type of "attn_func" [has-type]

Check failure on line 717 in vllm/attention/backends/rocm_flash_attn.py

View workflow job for this annotation

GitHub Actions / mypy (3.12)

Cannot determine type of "attn_func" [has-type]
q=query,
k=key,
v=value,
Expand All @@ -717,6 +726,7 @@
causal=True,
window_size=self.sliding_window,
alibi_slopes=self.alibi_slopes,
softcap=self.logits_soft_cap,
)

# common code for prefill
Expand Down
Loading