Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix max_seqlens_q/k initialization for Navi GPUs #310

Merged
merged 1 commit into from
Dec 9, 2024
Merged

Fix max_seqlens_q/k initialization for Navi GPUs #310

merged 1 commit into from
Dec 9, 2024

Conversation

hyoon1
Copy link

@hyoon1 hyoon1 commented Dec 7, 2024 •
edited by github-actions bot
Loading

  • max_seqlens_q/k variables were not correctly initialized for Navi GPUs leading to incorrect outputs.
    (Fix kernel cache miss and add RDNA configs #246)
  • ensure that the correct values are passed to the attn_fwd kernel based on the GPU type.

@hyoon1
Fix max_seqlens_q/k initialization for Navi GPUs
1605cf8 
- max_seqlens_q/k variables were not correctly initialized for Navi GPUs leading to incorrect outputs.
- ensure that the correct values are passed to the attn_fwd kernel based on the GPU type.
@hyoon1 hyoon1 requested a review from gshtras December 7, 2024 09:07
@hyoon1 hyoon1 changed the base branch from main to develop December 7, 2024 09:08
@hyoon1 hyoon1 requested a review from maleksan85 December 7, 2024 09:09
gshtras
gshtras approved these changes Dec 9, 2024
View reviewed changes
Copy link
Collaborator

@gshtras gshtras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is possible that this change only masks the original issue
Approving since it likely won't affect the MI path
Pending further investigation and a proper fix and/or understanding of the underlying issue

@gshtras gshtras merged commit 679a15c into ROCm:develop Dec 9, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gshtras gshtras gshtras approved these changes

@maleksan85 maleksan85 Awaiting requested review from maleksan85

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hyoon1 @gshtras