Fix idm remove #16473
Merged
Fix idm remove #16473
+12
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Megamouse
force-pushed
the
idm_remove
branch
from
538d77f to
62aeec4
Compare
|
I see, instead, you can fix the definition is_stx_pointer to check for null_,ptr_t as well |
idm remove calls shared_ptr::exchange with a null_ptr. This calls the stored object's constructor with null args. Let's just add an exchange overload for null_ptr
Megamouse
force-pushed
the
idm_remove
branch
from
62aeec4 to
915aa57
Compare
elad335
reviewed
Dec 29, 2024
| || is_instance_of<std::remove_cvref_t<T1>, shared_ptr>::value | ||
| || is_instance_of<std::remove_cvref_t<T1>, single_ptr>::value | ||
| || is_instance_of<std::remove_cvref_t<T1>, atomic_ptr>::value; | ||
| || std::is_same_v<std::remove_cvref_t<T1>, null_ptr_t>; |
There was a problem hiding this comment.
We need to thank C++ gods that std::is_same accepts incomplete types for this ;)
|
if I can provide a suggestion to help/simplify the user's life on testing/reporting issues, it should be better (when possible as in case of a regression) to provide info about which previous PR broke/changed something that was previously working. It will keep track of the chain of changes helping the users to easily identify the PRs to double check (possibly regressed, not regressed etc.) |
|
Why are you randomly changing my code? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
idm remove calls shared_ptr::exchange with a null_ptr.
This calls the stored object's constructor with null args.
Let's just add an exchange overload for null_ptr
fixes #16457
fixes #16458