Fix delete drawing tool to respect the selected layer #4263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather than `DeleteDrawingTool` rolling its own layer selection, we now use the selection provided by `DefaultTool`.
`PointerTool` and `AbstractDrawingTool` now use the layer selection from `DefaultTool` rather than reaching out to the zone renderer directly. To support this, the `DefaultTool` now updates its selected layer when attaching to the renderer.
Instead of the dialog having to discover the current renderer, we now have the tools directly set the layer it should present as selected. This removes an unnecessary assumption in `LayerSelectionDialog` while also making it clear in `DefaultTool` that the dialog is being updated to use the same layer expected by the tool.
kwvanderlinde
force-pushed
the
bugfix/4258-delete-drawing-tool-does-not-respect-selected-layer
branch
from
c61a93b
to
233a092
Compare
cwisniew
approved these changes
Aug 26, 2023
kwvanderlinde
deleted the
bugfix/4258-delete-drawing-tool-does-not-respect-selected-layer
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Identify the Bug or Feature request
Fixes #4258
Description of the Change
The bug fix is to remove
DeleteDrawingTool'sselectedLayerfield (which is never changed from the Token layer), and instead rely onDefaultTool.getSelectedLayer()when the layer is needed.There is also a bit of related refactoring to make
DefaultTool.getSelectedLayer()the only place we obtain the current layer for drawing tools, and so theLayerSelectionDialogalso does not have to figure that out itself.Possible Drawbacks
Should be none.
Documentation Notes
N/A
Release Notes
This change is