VBL Excluding #4838
Open
VBL Excluding #4838
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Doesn't work, but almost does.
setTokenVBLImmunity Macro also doesn't work yet.
|
@kwvanderlinde do you wish to have a go at reviewing this as you have had your head in the code in this area more recently than I have? If you don't have time I can do it. |
|
Yeah I'll have a look. Though I think this could use some discussion at the feature level - it's related to a bunch of other FRs that are better backed by use cases, so I'd like to see how it works together with some of those other ideas. I'll try to get some of that discussion going soon. |
|
At this point, this is probably the best I can do with this. I think it's usable (or salvageable) as is - aside from the ugly GUI bits. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Identify the Bug or Feature request
closes #4836
Description of the Change
Unfinished Implementation of VBL Excluding per token. Needs review by someone who knows vision systems better
Possible Drawbacks
Forces frequent regeneration of Vision Areas - performance detriment
Documentation Notes
Adds macro functions to get and set map and token VBL immunity on a token.
When set, that token's vision is not effected by that map/token topology.
Release Notes
Added ability for token to ignore specific topology.
This change is