#4961 #5008 #4954 Bug Fixes

[Jmr3366]

Fixes:
#4961 NPE on mouse off (needs testing, I can't validate)
#5008 Stat sheet not in front
#4954 User Overlays break with new statsheets

Description of the Change

#4961 adds an empty var if check. Needs testing as I don't have the OS to validate this change on.
#5008 changed variable used from min to max
#4954 forces sorting for all overlays (removed needsSorting bool)

Possible Drawbacks

None

---

This change is 

[cwisniew]

This overlay may be used in other functionality in the future so the name can't be hard coded like this

[Jmr3366]

It needs more work, I'm still missing something

edit
Created a new init in HTMLOverlayPanel using invokeLater being executed in initialize

[kwvanderlinde]

It needs more work, I'm still missing something

@Jmr3366 At a glance this look good to me. Is this comment still true?

[Jmr3366]

I think it is all good but wanted you or Craig to QC it.

[kwvanderlinde]

I think this approach to fixing #4954 actually masks the issue rather than fixing it. Did some testing, I believe the only thing that needs to change is in showOverlay() - we need needsSorting to be true even for internal overlays. Otherwise the new overlay ends up in front of the front region.

Also I have a personal motivation to not have overlays automatically open 🙂 - see #5044. Overlays on my system cause a lot of input lag, and this would force me to endure it despite not using the stat sheet feature yet.

[Jmr3366]

You're correct on both points (masking,sorting) and I looked right past that, thank you sir!