Remove topology type selections from zones #5042
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Everwhere else we use `Set<TopologyType>` as it is functionally equivalent. We keep the field around because persisted `Zone`s still need to be able to read its contents.
`Zone` no longer needs to keep track of its own mode selection, freeing the application from having to keep the selector in sync with the current `Zone`. This also makes the selector more self-contained, no longer depending on the global state it used to need to keep the current `Zone` up to date. Operations that previously queried the zone for the current mode selection now query the selector.
We don't need the null case anymore in `AppStatePersisted.setTopologyTypes()`, and we can make the output format explicit rather than accepting whatever `toString()` throws at us.
…odeSelectionPanel
kwvanderlinde
force-pushed
the
feature/5014-dissociate-topology-type-from-zone
branch
from
125dbd3
to
9a4f5e7
Compare
cwisniew
approved these changes
Nov 14, 2024
cwisniew
approved these changes
Nov 14, 2024
kwvanderlinde
deleted the
feature/5014-dissociate-topology-type-from-zone
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Identify the Bug or Feature request
Closes #5014
Description of the Change
Individual zones no longer keep their own topology type selection. Instead this state is kept in
AppStatePersistedand is reflected in the toolbar's topology type selector. There is no more bookkeeping required to keep the toolbar and the current zone's topology types in sync with each other.The
Zone.TopologyTypeSetclass is also redundant now thatZoneno longer has a field of that type to serialize. It has been removed in favour ofSet<TopologyTypeSet>/EnumSet<TopologyTypeSet>.Possible Drawbacks
None
Documentation Notes
N/A
Release Notes
This change is