Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature to lock an overlay #5051

Merged
merged 1 commit into from
Nov 19, 2024
Merged

Conversation

Jmr3366
Copy link
Contributor

@Jmr3366 Jmr3366 commented Nov 18, 2024

Closes #3414 by adding a locked option in overlay

Description of the Change

Extended the 2nd parameter offered in overlay.
Like zorder=<num> you can now add locked=<0/1>.
locked defaults to 0 (not locked)

Locked overlays appear in the Window -> Overlays menu but are greyed out and can't be unchecked

Possible Drawbacks

None

Release Notes

Examples:
[overlay("Test","zOrder=10;locked=1;"):[ { content to display }]


This change is Reviewable

@Jmr3366
Copy link
Contributor Author

Jmr3366 commented Nov 18, 2024

Is there a known process/procedure to mitigate this (sometimes it happens, other times not)?
image

@kwvanderlinde
Copy link
Collaborator

Is there a known process/procedure to mitigate this (sometimes it happens, other times not)? image

You can avoid it by not using closing keywords in the PR (e.g., just write "#3414" instead of "closes #3414"). After the jobs run the description can be updated.

But I think we ought to remove the job until we know what's wrong with it.

@cwisniew
Copy link
Member

Is there a known process/procedure to mitigate this (sometimes it happens, other times not)? image

You can avoid it by not using closing keywords in the PR (e.g., just write "#3414" instead of "closes #3414"). After the jobs run the description can be updated.

But I think we ought to remove the job until we know what's wrong with it.

I am in two minds as when it works it means I don't have to do anything before merging, when it fails it at least reminds me to assign the label to the PR

Otherwise I end up spending too much time on release chasing down all the PRs and assigning them labels so the release notes get created correctly. Is it perfect no but it's better than when it wasn't there. Also please don't leave off the keywords that close PRs as that creates more work and I will soon get annoyed enough I will start rejecting them :)

@cwisniew cwisniew added this pull request to the merge queue Nov 19, 2024
@cwisniew cwisniew added the feature Adding functionality that adds value label Nov 19, 2024
Merged via the queue into RPTools:develop with commit 5a083a5 Nov 19, 2024
4 of 5 checks passed
@cwisniew cwisniew changed the title #3414 Feature to lock an overlay Feature to lock an overlay Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Adding functionality that adds value
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: Allow GM to Lock Overlays.
3 participants