Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a start/stop lifecycle for ServerCommandClientImpl #5053

Merged

Conversation

kwvanderlinde
Copy link
Collaborator

@kwvanderlinde kwvanderlinde commented Nov 18, 2024

Identify the Bug or Feature request

Fixes #5052

Description of the Change

ServerCommandClientimpl can now be stopped when the MapToolClient is closed. This shuts down the TimedEventQueue thread, in turn allowing the ServerCommandClientImpl, MapToolClient and Campaign to be garbage collected.

Some minor related edits:

  • Removed an unncessary synchronized block from TimedEventQueue.
  • Fixed AssetProducerThread.shutdown() to use an AtomicBoolean instead of a plain boolean.

Possible Drawbacks

None

Documentation Notes

N/A

Release Notes

  • Fixed a bug where unloaded campaigns would remain in memory.`

This change is Reviewable

@kwvanderlinde kwvanderlinde self-assigned this Nov 18, 2024
@kwvanderlinde kwvanderlinde added bug code-maintenance Adding/editing javadocs, unit tests, formatting. labels Nov 18, 2024
@cwisniew cwisniew added this pull request to the merge queue Nov 19, 2024
Merged via the queue into RPTools:develop with commit 8d07b22 Nov 19, 2024
5 checks passed
@kwvanderlinde kwvanderlinde deleted the bugfix/5052-ServerCommand-memory-leak branch November 19, 2024 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug code-maintenance Adding/editing javadocs, unit tests, formatting.
Projects
Status: Merged
Development

Successfully merging this pull request may close these issues.

[Refactoring]: ServerCommand memory leak
2 participants