Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add landing maps to campaigns #5055

Merged
merged 3 commits into from
Nov 19, 2024

Conversation

kwvanderlinde
Copy link
Collaborator

@kwvanderlinde kwvanderlinde commented Nov 19, 2024

Identify the Bug or Feature request

Resolves #75

Description of the Change

Adds a zone ID to the Campaign to mark it as the landing map for players. When a remote player client connects, if the campaign has a landing map set, it will use that. Otherwise it will fall back to the current behaviour of finding the first player-visible map.

This does not affect GMs - they still open the first map in the list when they connect. And local clients will still try to stay on the current zone if possible.

Possible Drawbacks

None

Documentation Notes

Use the Map > Landing map toggle to set the current map as the landing map:
landing-map-menu-item

Release Notes

  • Added a Map menu option to set the current map as a landing map for when players connect to the server.

This change is Reviewable

Each `Campaign` now stores the ID of its landing map, if one is set. The user sets one using from the app menu,
_Map > Set as landing map_. When a player client connects and the campaign has a landing map set, the client will look
up that landing map to display first.

This does not apply to GM clients. Also, the local client will prefer to stay on the current map if possible when
starting and stopping a server.
@kwvanderlinde kwvanderlinde added the feature Adding functionality that adds value label Nov 19, 2024
@kwvanderlinde kwvanderlinde self-assigned this Nov 19, 2024
@kwvanderlinde kwvanderlinde marked this pull request as ready for review November 19, 2024 04:43
@cwisniew cwisniew added this pull request to the merge queue Nov 19, 2024
Merged via the queue into RPTools:develop with commit 0313658 Nov 19, 2024
5 checks passed
@kwvanderlinde kwvanderlinde deleted the feature/75-landing-map branch November 19, 2024 06:05
@FullBleed
Copy link

This is great! I have a onCampaignLoad that handles this sort of thing but this is a long overdue feature to gives users control over what map users are sent to.

Would like to see this supported with set/getLandingMap() functions and a checkbox in the New Map and Edit Dialogs. Should I put in a freq for those?

@cwisniew
Copy link
Member

This is great! I have a onCampaignLoad that handles this sort of thing but this is a long overdue feature to gives users control over what map users are sent to.

Would like to see this supported with set/getLandingMap() functions and a checkbox in the New Map and Edit Dialogs. Should I put in a freq for those?

Hold off maybe on the macro one as it would be good to get feedback on the related functionality for setting the starting viewable area first before creating the macros. UI changes are easy to make based on feedback, once a macro function is created its kinda stuck that way forever.

@kwvanderlinde
Copy link
Collaborator Author

@FullBleed I'll tack on another PR for the edit map dialog. Will be pretty simple and I think natural to keep part of #75.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Adding functionality that adds value
Projects
Status: Merged
Development

Successfully merging this pull request may close these issues.

Set Landing Map for Client Connect
3 participants