-
Notifications
You must be signed in to change notification settings - Fork 263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Token class updates to accommodate new layout features #5104
Open
bubblobill
wants to merge
30
commits into
RPTools:develop
Choose a base branch
from
bubblobill:TokenLayout
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clean up some property names, e.g. isFlippedIso to flippedIso so that getter becomes isFlippedIso(). Unnecessary Token removed from property tokenOpacity. Now just opacity. Reordered to keep layout props together. Added new layout prop imageRotation Updated tokenLayoutProp macro functions
bubblobill
added
feature
Adding functionality that adds value
claimed
Issue is being actively worked on.
refactor
Refactoring the code for optimal awesomeness.
labels
Dec 11, 2024
Yay, it runs, and I am reminded why methods should be properly named the first time. |
cwisniew
requested changes
Dec 11, 2024
src/main/java/net/rptools/maptool/client/ui/token/dialog/edit/EditTokenDialog.java
Outdated
Show resolved
Hide resolved
src/main/java/net/rptools/maptool/client/ui/token/dialog/edit/TokenLayoutPanelHelper.java
Outdated
Show resolved
Hide resolved
src/main/java/net/rptools/maptool/client/ui/token/dialog/edit/TokenLayoutPanelHelper.java
Outdated
Show resolved
Hide resolved
…ented code. Commented code removed
Token drawing moved to TokenRenderer Facing-arrow painting moved to FacingArrowRenderer Some functionality moved to ImageUtils
Remove old layout panel
Icons embedded
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #5103
Progresses #5096
Progresses #3691
Includes most of #5097
Description of the Change
New property
New property macro functions
Refactoring
Possible Drawbacks
none
Documentation Notes
n/a
Release Notes
n/a
This change is