Skip to content

Commit

Permalink
Feeling 'dev' compatibility is better
Browse files Browse the repository at this point in the history
  • Loading branch information
wjz304 committed Jun 23, 2023
1 parent 9c16b66 commit 438b344
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion files/board/arpl/overlayfs/opt/arpl/init.sh
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ ETHX=(`ls /sys/class/net/ | grep eth`) # real network cards list
# If user config file not exists, initialize it
if [ ! -f "${USER_CONFIG_FILE}" ]; then
touch "${USER_CONFIG_FILE}"
writeConfigKey "lkm" "prod" "${USER_CONFIG_FILE}"
writeConfigKey "lkm" "dev" "${USER_CONFIG_FILE}"
writeConfigKey "directboot" "false" "${USER_CONFIG_FILE}"
writeConfigKey "notsetmacs" "false" "${USER_CONFIG_FILE}"
writeConfigKey "bootipwait" "10" "${USER_CONFIG_FILE}"
Expand Down

11 comments on commit 438b344

@AuxXxilium
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are you sure it is working with more than 2 disks connected? that was the issue, that user are not able to boot with more than 2 connected disks.

@wjz304
Copy link
Contributor Author

@wjz304 wjz304 commented on 438b344 Jun 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are you sure it is working with more than 2 disks connected? that was the issue, that user are not able to boot with more than 2 connected disks.

I tested 920+and 3622xs+ with 3 virtual hard drives in PVE, and it seems that there are no issues,
What is the problematic environment like? I did see some people talking about it, but there has been no log. I haven't reproduced it.

@AuxXxilium
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the issue was somewhere in debug code from dev lkm.

@wjz304
Copy link
Contributor Author

@wjz304 wjz304 commented on 438b344 Jun 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, then I'll change it back first

@AuxXxilium
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i will try it here to find out if it is working now. we have changed some things in lkm since the issue was there. will report back asap.

@AuxXxilium
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i tried on multiple systems, can't bring the issue back and serial log is also clean. so it looks like, latest changes in lkm will work. i think it's safe for now to use "dev".

@wjz304
Copy link
Contributor Author

@wjz304 wjz304 commented on 438b344 Jun 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I saw many people complaining that they couldn't find the IP, and when they switched to dev, it seemed to have eased,
but no one provided logs, I'll try again tomorrow, too.
it's 2am Chinese time now, and I'm dozing off, I'm ready to break.
I wish you a good dream tonight, too. :)

@AuxXxilium
Copy link

@AuxXxilium AuxXxilium commented on 438b344 Jun 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wish you, too.

we will figure it out ;)

looks like "dev" fixes the ip issue but causes an issue that powerbutton will not work.

@wjz304
Copy link
Contributor Author

@wjz304 wjz304 commented on 438b344 Jun 25, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wish you, too.

we will figure it out ;)

looks like "dev" fixes the ip issue but causes an issue that powerbutton will not work.

I received a response today stating that if it exceeds 2 SSDs, it will not start,
As I currently do not have as many SSDs for testing, I used PVE to simulate three SSD virtual hard disks and they are still OK,
I don't know what the physical machine is like? If it's convenient for you, you can give it a try. If it's not convenient, just for a knowledge

@AuxXxilium
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i tried on physical and everything was OK. but to make sure that everything is working, we should use "prod".

@wjz304
Copy link
Contributor Author

@wjz304 wjz304 commented on 438b344 Jun 25, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's keep the prod for now. If anyone has a problem, let them try to modify it themselves

Please sign in to comment.