Validate input and add test case

Signed-off-by: Rafael Raposo <[email protected]>
RRap0so · Mar 18, 2024 · bea1a0b · bea1a0b
1 parent 12caf27
commit bea1a0b
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 0 deletions.
diff --git a/flyteadmin/pkg/manager/impl/project_manager.go b/flyteadmin/pkg/manager/impl/project_manager.go
@@ -128,6 +128,9 @@ func (m *ProjectManager) UpdateProject(ctx context.Context, projectUpdate admin.
 }
 
 func (m *ProjectManager) GetProject(ctx context.Context, request admin.ProjectGetRequest) (*admin.Project, error) {
+	if request.Id == "" {
+		return nil, errors.NewFlyteAdminErrorf(codes.InvalidArgument, "project identifier is required")
+	}
 	projectModel, err := m.db.ProjectRepo().Get(ctx, request.Id)
 	if err != nil {
 		return nil, err

diff --git a/flyteadmin/pkg/manager/impl/project_manager_test.go b/flyteadmin/pkg/manager/impl/project_manager_test.go
@@ -321,3 +321,16 @@ func TestProjectManager_TestGetProject_ErrorDueToProjectNotFound(t *testing.T) {
 
 	assert.Equal(t, errors.New("project "+project+" not found"), err)
 }
+
+func TestProjectManager_TestGetProject_ErrorDueToEmptyProjectGetRequest(t *testing.T) {
+	mockRepository := repositoryMocks.NewMockRepository()
+	mockedProject := &admin.ProjectGetRequest{Id: ""}
+
+	projectManager := NewProjectManager(mockRepository, runtimeMocks.NewMockConfigurationProvider(
+		getMockApplicationConfigForProjectManagerTest(), nil, nil, nil, nil, nil))
+
+	_, err := projectManager.GetProject(context.Background(),
+		*mockedProject)
+
+	assert.EqualError(t, err, "project identifier is required")
+}