Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get project endpoint #3

Closed
wants to merge 17 commits into from
Prev Previous commit
Next Next commit
address comments
Signed-off-by: Rafael Raposo <[email protected]>
RRap0so committed Mar 18, 2024
commit e9bb20ad192c54b56711036303dc197ff3b25054
4 changes: 2 additions & 2 deletions flyteadmin/pkg/rpc/adminservice/project.go
Original file line number Diff line number Diff line change
@@ -75,9 +75,9 @@ func (m *AdminService) GetProject(ctx context.Context, request *admin.ProjectGet
response, err = m.ProjectManager.GetProject(ctx, *request)
})
if err != nil {
return nil, util.TransformAndRecordError(err, &m.Metrics.projectEndpointMetrics.list)
return nil, util.TransformAndRecordError(err, &m.Metrics.projectEndpointMetrics.get)
}

m.Metrics.projectEndpointMetrics.list.Success()
m.Metrics.projectEndpointMetrics.get.Success()
return response, nil
}
40 changes: 0 additions & 40 deletions flyteidl/clients/go/assets/admin.swagger.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

810 changes: 404 additions & 406 deletions flyteidl/gen/pb-go/flyteidl/service/admin.pb.go

Large diffs are not rendered by default.

123 changes: 0 additions & 123 deletions flyteidl/gen/pb-go/gateway/flyteidl/service/admin.pb.gw.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

40 changes: 0 additions & 40 deletions flyteidl/gen/pb-go/gateway/flyteidl/service/admin.swagger.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions flyteidl/gen/pb_python/flyteidl/service/admin_pb2.py

Large diffs are not rendered by default.

3 changes: 0 additions & 3 deletions flyteidl/protos/flyteidl/service/admin.proto
Original file line number Diff line number Diff line change
@@ -399,9 +399,6 @@ service AdminService {
rpc GetProject (flyteidl.admin.ProjectGetRequest) returns (flyteidl.admin.Project) {
option (google.api.http) = {
get: "/api/v1/projects/{id}"
additional_bindings {
get: "/api/v1/projects/org/{org}/{id}"
}
};
option (grpc.gateway.protoc_gen_openapiv2.options.openapiv2_operation) = {
description: "Fetch a registered projects."