feat: Implement the webview sandbox using a microfront end for rn to implement the full html renderer #2691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Innei <[email protected]>
Signed-off-by: Innei <[email protected]>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
|
Suggested PR Title: Change Summary: Code Review: |
- Refactor SharedWebView module with improved JavaScript injection and link handling - Add ModalWebViewController for opening links in a modal view - Implement dynamic content height measurement - Update HTML renderer with Jotai state management - Improve WebView configuration and debug mode Signed-off-by: Innei <[email protected]>
Signed-off-by: Innei <[email protected]>
|
Linting and formatting issues were automatically fixed. Please review the changes. |
- Remove debug-only conditional for WebView inspector - Add text label class to GroupedInsetListActionCell for consistent styling Signed-off-by: Innei <[email protected]>
Signed-off-by: Innei <[email protected]>
- Create custom WKWebView subclass to override safe area insets - Enables full-screen WebView rendering without default padding Signed-off-by: Innei <[email protected]>
- Delete unused custom WKWebView subclass for iOS - Cleanup unnecessary file after previous implementation Signed-off-by: Innei <[email protected]>
Signed-off-by: Innei <[email protected]>
- Add HelperModule for iOS to open links in a modal WebView - Implement cross-platform link opening mechanism - Enhance entry detail screen with dynamic title and scroll behavior - Add loading indicator for entry content - Refactor navigation and scroll view components Signed-off-by: Innei <[email protected]>
- Dispatch JavaScript evaluation and URL loading on the main thread - Ensure thread-safe WebView interactions for iOS - Prevent potential race conditions in SharedWebViewModule Signed-off-by: Innei <[email protected]>
…hanism - Replace custom useOpenLink hook with native openLink function - Update WebView navigation and recommendation list item to use new link opening method - Remove unnecessary hook and simplify link handling Signed-off-by: Innei <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ScreenRecording_02-07-2025.11-03-14_1.MP4