Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some tweaks to the project creation code #316

Merged
merged 3 commits into from
May 6, 2024
Merged

Conversation

AstridKery
Copy link
Contributor

  • remove full file limit (allow users to upload files with no unlabeled data)
  • when someone uploads a file with labels not defined in step 2, just print the extra labels instead of both full label sets (this works much better when there are many labels)

@AstridKery AstridKery requested a review from andykawabata April 26, 2024 20:54
@AstridKery AstridKery self-assigned this Apr 26, 2024
@AstridKery
Copy link
Contributor Author

Things to look for in this merge request

  • when someone is looking to upload data to the project, SMART should no longer throw an error if the file only has labeled data. Reviewers should make sure that uploading a full file when creating the project doesn't lead to any unexpected behavior downstream in the project (i.e. when someone goes to the annotate page, when someone uploads unlabeled data), especially in the cases where the modeling or active learning features are turned on.
  • try uploading a label file with a new label not defined in step 2 and see if the error printed to the user makes sense
  • look at the label upload directions and see if they make sense

Copy link
Contributor

@andykawabata andykawabata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good as far as I can tell.

  • I uploaded a fully labelled dataset and could not break anything while clicking through annotation pages
  • The error message when uploading data with bad labels was clear. Worked both on the initial data upload and when updating data.
  • The label upload instruction seemed mostly clear. I did leave one comment with a suggestion.

@AstridKery AstridKery merged commit 9956e50 into dev May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants