Documentation revision #9
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
puckybreg
reviewed
Jul 26, 2024
| @@ -10,19 +10,29 @@ export default { | |||
| text: 'Introduction', | |||
| collapsible: true, | |||
| items: [ | |||
| {text: 'About', link: '/introduction/'}, | |||
| {text: 'About', link: '/introduction/index'}, | |||
There was a problem hiding this comment.
The in-page nav is not properly indicating the active selection for the about item. I think it might be because this page is not called /introduction/about?
| @@ -0,0 +1,165 @@ | |||
| # Writing Filter Components | |||
| Writing filter components in Harness-Vue is easy thanks to Vue and Pinia. Filters in Harness-Vue as abstractions around a pinia store - but at their core, they have a getter (`getFilter`) and a setter (`setFilter`). | |||
There was a problem hiding this comment.
Suggested change
| Writing filter components in Harness-Vue is easy thanks to Vue and Pinia. Filters in Harness-Vue as abstractions around a pinia store - but at their core, they have a getter (`getFilter`) and a setter (`setFilter`). | |
| Writing filter components in Harness-Vue is easy thanks to Vue and Pinia. Filters in Harness-Vue are abstractions around a pinia store - but at their core, they have a getter (`getFilter`) and a setter (`setFilter`). |
I believe there is a typo here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is intended to capture a number of documentation revisions based on internal discussion. I expect this list to grow before merged in.