Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Conversion from Matlab's 1-based indexing to Python's 0-based indexing is needed. #1

Open
wknoben opened this issue May 23, 2024 · 0 comments
Open

Conversion from Matlab's 1-based indexing to Python's 0-based indexing is needed. #1

wknoben opened this issue May 23, 2024 · 0 comments

Comments

@wknoben
Copy link

wknoben commented May 23, 2024

pymarrmot/src/pymarrmot/Models/Models/marrmot_model.py

Line 540 in 5337dee

cal_idx = np.arange(1,len(Q_obs)+1)

This is an example of a case where the conversion Matlab -> Python leads to incorrect indexing in the Python code. In this cal_idx should be:

cal_idx = np.arange(0,len(Q_obs))

Unsure if there are other occurrences like this, but it seems likely that there will be.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@wknoben