353 new member field breaks create joined timeseries on existing datasets #355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samlamont
approved these changes
Dec 18, 2024
| if add_missing_columns: | ||
| for col_name in schema_cols: | ||
| if col_name not in df.columns: | ||
| df = df.withColumn(col_name, lit(None)) |
There was a problem hiding this comment.
just to make sure I understand, here we're adding an empty column(s) (column names that exist in the schema but not dataframe), then in line 186 it coerces the empty column(s) to the correct data type as defined by the schema?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@samlamont This is kind of a bug fix as the remote datasets on S3 do not have the
memberfield. This is mostly ok because thejoined_timeseriestable has been generated and is alos stored in S3. But if the user wants to clone the Evaluation from S3 and then recreate thejoined_timeseriestable it fails because thesecondary_timeseriesdoe snot pass validation. I added a `add_missing_fields arg and code to the BaseTable which can be used to fix this by forcing and read, validate and write. We need to do this on all the datasets in S3 (that we also have in teehr-hub) and re-sync. With that, I'd like to get this merged ASAP.