Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only add configuration name if it does not already exist #398

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

samlamont
Copy link
Collaborator

@samlamont samlamont commented Mar 6, 2025

Adds logic in fetching to:

  • check if configuration name exists in the configurations table
  • automatically adds configuration name if it does not exist in the table, if it does exist continue with loading
  • remove add_configuration_name flag since it seems unnecessary and could cause problems. I can't think of a reason why the name shouldn't be added if it doesn't exist, since validation will then fail

Resolves #397

@samlamont samlamont requested review from mgdenno and samland1116 March 6, 2025 15:02
@samlamont samlamont marked this pull request as draft March 6, 2025 15:18
@samlamont samlamont marked this pull request as ready for review March 6, 2025 15:52
Copy link
Contributor

@samland1116 samland1116 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code updates seem clear and concise, tests pass on my end

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot load additional data after any data of same type/configuration previously loaded
2 participants