ISHEvent and ISHBackgroundTask field information is checked to add th… #172
Conversation
…em to theishTypeFieldDefinitions.
| xmlDocument.LoadXml(xmlIshFieldSetup); | ||
|
|
||
| if (xmlDocument.SelectSingleNode("//ishtypedefinition[@name='ISHEvent']") != null) |
There was a problem hiding this comment.
Detecting based on the Xml means that it is API 2.5 (SOAP) API dependent... When this code is rewired to OpenAPI (JSON) then we have to adjust this code as well
| AddIshBackgroundTaskTableFieldSetup(); | ||
| AddIshEventTableFieldSetup(); | ||
| AddIshTranslationJobItemTableFieldSetup(); | ||
| if (!hasIshBackgroundTaskFieldDefinitions) |
There was a problem hiding this comment.
Instead of using the earlier "detected" boolean (via de xml xpath expression) ... can you not simply check if the _ishTypeFieldDefinitions object at this point already holds ISHEvent and use that as the if-clause to decide the hardcoded piece or not...
| if (!hasIshBackgroundTaskFieldDefinitions) | ||
| { AddIshBackgroundTaskTableFieldSetup(); } | ||
| if (!hasIshEventFieldDefinitions) | ||
| { AddIshEventTableFieldSetup(); } |
There was a problem hiding this comment.
Previous code had
- AddIshBackgroundTaskTableFieldSetup
- AddIshEventTableFieldSetup
- AddIshTranslationJobItemTableFieldSetup <-- where is this in your code?
There was a problem hiding this comment.
Previously we had an empty method AddIshTranslationJobItemTableFieldSetup which is not used...so do you really want to keep this empty method and put a check around it?
There was a problem hiding this comment.
Although commented out, it was still a building block on route to #69 ... preferably the RetrieveTypeFieldSetup API call offers these two object types as well.
| ishTypeFieldDefinitions.Add(new IshTypeFieldDefinition(_logger, Enumerations.ISHType.ISHBackgroundTask, Enumerations.Level.History, false, false, true, false, false, false, false, true, true, false, "STARTDATE", Enumerations.DataType.DateTime, "", "", "The date time that this execution of the background task was started")); | ||
| ishTypeFieldDefinitions.Add(new IshTypeFieldDefinition(_logger, Enumerations.ISHType.ISHBackgroundTask, Enumerations.Level.History, false, false, true, false, false, false, false, true, true, false, "ENDDATE", Enumerations.DataType.DateTime, "", "", "The date time that this execution of the background task was finished")); | ||
| ishTypeFieldDefinitions.Add(new IshTypeFieldDefinition(_logger, Enumerations.ISHType.ISHBackgroundTask, Enumerations.Level.History, false, false, true, false, false, false, false, true, true, false, "HOSTNAME", Enumerations.DataType.String, "", "", "The host name from which the background task was created")); | ||
| var ishTypeFieldDefinitions = new List<IshTypeFieldDefinition> |
There was a problem hiding this comment.
Can I assume that this change is just layout, and not actual changes... did not compare line-by-line?
There was a problem hiding this comment.
The layout is changed to resolve the warning.
| ishTypeFieldDefinitions.Add(new IshTypeFieldDefinition(_logger, Enumerations.ISHType.ISHBackgroundTask, Enumerations.Level.History, false, false, true, false, false, false, true, true, false, "STARTDATE", Enumerations.DataType.DateTime, "", "The date time that this execution of the background task was started")); | ||
| ishTypeFieldDefinitions.Add(new IshTypeFieldDefinition(_logger, Enumerations.ISHType.ISHBackgroundTask, Enumerations.Level.History, false, false, true, false, false, false, true, true, false, "ENDDATE", Enumerations.DataType.DateTime, "", "The date time that this execution of the background task was finished")); | ||
| ishTypeFieldDefinitions.Add(new IshTypeFieldDefinition(_logger, Enumerations.ISHType.ISHBackgroundTask, Enumerations.Level.History, false, false, true, false, false, false, true, true, false, "HOSTNAME", Enumerations.DataType.String, "", "The host name from which the background task was created")); | ||
| //internal IshTypeFieldDefinition(ILogger logger, Enumerations.ISHType ishType, Enumerations.Level level, bool isMandatory, bool isMultiValue, bool allowOnRead, bool allowOnCreate, bool allowOnUpdate, bool allowOnSearch, bool isSystem, bool isBasic, bool isDescriptive, string name, Enumerations.DataType dataType, string referenceLov, string description) |
There was a problem hiding this comment.
Same here... only layout?
There was a problem hiding this comment.
Yes, only layout..
| foreach (var ishTypeFieldDefinition in ishTypeFieldDefinitions) | ||
| { | ||
| { | ||
| _ishTypeFieldDefinitions.Add(ishTypeFieldDefinition.Key, ishTypeFieldDefinition); | ||
| } | ||
| } | ||
|
|
||
| private void AddIshEventTableFieldSetup() |
There was a problem hiding this comment.
Where is AddIshTranslationJobItemTableFieldSetup() function as mentioned earlier?
… to see if field information is needed to be added manually.
…em to theishTypeFieldDefinitions.