Issue #75 - Improved processing of non published assets, including versioning #84
Conversation
…g versioning - see issue RWS#75
| * @return {@code true} if the specified URL refers to static content within the webapp, {@code false} otherwise. | ||
| * @param url a {@link java.lang.String} object. | ||
| */ | ||
| boolean isNonPublishedAsset(String url); |
There was a problem hiding this comment.
need default implementation that always returns false to not to break compatibility
There was a problem hiding this comment.
How would compatibility be broken exactly? As far as I can see there would only be a problem in the situation where the HTML files were published from the CMS and you had put a _version.json file on the web app filesystem or dxa.assets.version property in dxa.properties - which would be a non-sensical situation, but still one which you would resolve by simply removing the file/property
There was a problem hiding this comment.
@willprice76 all these comments in all the PRs from are now for internal usage, so don't worry and ignore all of them :) We cannot merge all your PRs to 1.7 release on github, and we also have internal conventions on how to merge PRs from GitHub (happens through stash quality gate).
Regarding the comment itself: we have never defined what is really public API for DXA, so it doesn't hurt to add a default implementation to also support the case if anyone extended localization implementation or implemented their own localization.
…010 to develop * commit '137e519db5c2d6eec107e7d0ec749f0823e9b51b': TSI-3011 Typo fix (TSI-3010) TSI-3011 Review fix (TSI-3010) TSI-3011 Review fix (TSI-3010) TSI-3011 Added data model extensions to public API (TSI-3010) TSI-3010 Added advanced way to save type information without additional changes from CM side (TSI-3011) TSI-3010 Moved Conditions to webapp & added support of any classes in extension data (TSI-3011)
No description provided.