Fix param size (uint16_t) #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! Just as a note: The code here is newer and seems to be more stable because it uses libelf instead of libbfd. If it also works for your use case I would suggest having a look there. |
armaanchowfin
pushed a commit
to sam990/flyt
that referenced
this pull request
Nov 26, 2024
Fix param size (uint16_t)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I needed to get the parameters of cuda kernels for a unrelated project and fortunately found this wonderful project.
I used this code as inspiration.
It seemingly worked great but I had some issues for certain kernels and I tracked it down to the size being 0x0 when it should be 0x140.
After debugging the cuobjdump binary I found that the size is actually 16 bit.
As I am not actually using this project I don't know if any changes in other places are required, but I still wanted to contribute this in case it affects anybody else.