Skip to content

Contribute to AixLib

Peter Remmen edited this page Feb 24, 2016 · 21 revisions

Thanks for contributing to the AixLib, the following page describes tasks and responsibilites by changing code. We encourage you to follow this workflow, which is inspired by Annex60,BuildingSystem and IDEAS.

If you are a member of RWTH-EBC you can directly write to the repository. If you are not member you need to create a fork of AixLib.

Bugfixes

As a developer:

  1. Open a new issue in the Issues section, assign it to the one who can address it (which may be you) and apply the bug lable. The issue has to have a clear title (e.g. Bug in Class Y).
  2. Create a new branch starting from the master, call this branch according to the created issue 'issue##_BugClassY'
  3. Document your changes in rather small steps/commits. Try to use choose short commit messages (maximum 140 characters). You may want to include in the commit message a string such as #17. This will automatically add a link to the commit from the issue.
  4. Watch the evolution of the master if it changes, merge the latest version into your branch.
  5. Increase the version number in README and package.mo of AixLib in a single commit.
  6. Create a pull request with master as base and your branch as compare. And assign the pull request to someone for reviewing and merging it into the master.

As a reviwer/admin:

  1. When reviewing other's code, add your comments on the issue tracker. If the revisions need further work, assign these to the original author.
  2. If the revisions are reviewed and correct, accept the pull requests, delete the branch and close the issue. Whenever you accept a pull request into the master, you need to make sure to publish a new release. In the Releases section hit the Draft a new release button, enter the correct new version number and chose a self explaining release title (e.g. v0.2.0 or "Bugfix in Class Y"). Furthermore, create a pull request with development as base and master as compare, you can accept this pull request by yourself, as the changes have already been reviewed.

New/improve feature

As a developer:

  1. Open a new issue in the Issues section, assign it to the one who can address it (which may be you). The issue has to have a clear title (e.g. New Feature in Class X).
  2. Create a new branch starting from the development, call this branch according to the created issue 'issue##_FeatureClassY'
  3. Document your changes in rather small steps/commits. Try to use choose short commit messages (maximum 140 characters). You may want to include in the commit message a string such as #17. This will automatically add a link to the commit from the issue.
  4. Watch the evolution of the development if it changes, merge the latest version into your branch.
  5. Create a pull request with development as base and your branch as compare. And assign the pull request to someone for reviewing and merging it into the development.

As a reviewer:

  1. When reviewing other's code, add your comments on the issue tracker. If the revisions need further work, assign these to the original author.
  2. If the revisions are reviewed and correct, accept the pull requests, delete the branch and close the issue.
Clone this wiki locally