chore: include context conversion methods and test #393
Conversation
tests/models/test_ngsi_v2_context.py
Outdated
| @@ -623,6 +623,12 @@ def test_get_attributes(self): | |||
| self.assertNotEqual(entity.get_attributes(strict_data_type=True), attributes) | |||
| self.assertNotEqual(entity.get_attributes(), attributes) | |||
|
|
|||
| def test_context_conversion(self): | |||
| entity_normalized = ContextEntity(**self.entity_data) | |||
| entity_key_values = ContextEntityKeyValues(**self.entity_data) | |||
There was a problem hiding this comment.
I think this way the created entity_key_values is not really in keyvalue format.
Expected entity_key_values.model_dump_json()
{"id": "MyId", "type": "MyType", "temperature": 20, "relation": "OtherEntity"}Right now
{"id": "MyId", "type": "MyType", "temperature": {"value": 20, "type": "Number"}, "relation": {"value": "OtherEntity", "type": "Relationship"}}There was a problem hiding this comment.
I made adjustments accordingly. However, the test is failing, so the conversion functionality needs to be checked again.
There was a problem hiding this comment.
Hmm, now I am thinking, shouldn't the constructor of ContextEntityKeyValues class take care of the right format?
There was a problem hiding this comment.
Not really, I think the implementation was quite simple. There is no need to create model for AttributeKeyvalue. Because the entity can simply takes whatever it gets, as long as it is JSON serializable. It would be nice to have a simple validation mechanism for the AttributeKeyvalue, but not necessarily
For example, if we create an entity with keyvalue like that
{"id": "MyId", "type": "MyType", "temperature": {"value": 20, "type": "Number"}Orion will understand it as
{"id": "MyId", "type": "MyType",
"temperature": {
"type": "StructuredValue",
"value": {"value": 20, "type": "Number"}
}
No description provided.