Added support for additional VPC cidr block associations

[kieranbrown]

This module currently won't work for VPC's that have multiple CIDR block allocations due to the security group not allowing inbound traffic.

Also fixed (assumably) a typo on the aws_network_interface not using security groups passed into the module.

[RaJiska]

Thanks for the PR @kieranbrown. Indeed the changes would allow VPCs with multiple CIDRs to work. As for the security groups not passed to the network interface, please note that this isn't a typo.

The NAT instance has a fixed ENI which sole purpose is to be the "reliable interlocutor" between services that need to be NATed within the VPC and the NAT instance. The list of security groups is assigned to the public (ephemeral) ENI, cf ec2.tf.

The PR would be good to be merged once the change on the security group of the static ENI is reverted.

[kieranbrown]

Thanks for the PR @kieranbrown. Indeed the changes would allow VPCs with multiple CIDRs to work. As for the security groups not passed to the network interface, please note that this isn't a typo.

The NAT instance has a fixed ENI which sole purpose is to be the "reliable interlocutor" between services that need to be NATed within the VPC and the NAT instance. The list of security groups is assigned to the public (ephemeral) ENI, cf ec2.tf.

The PR would be good to be merged once the change on the security group of the static ENI is reverted.

Makes sense, I’ve reverted this change 👍

[RaJiska]

Thank you & merged, appreciated.