Adds changelog and solves pep8

Raahul-Singh · Jun 13, 2020 · 2f99d8a · 2f99d8a
1 parent 7f7432a
commit 2f99d8a
Show file tree

Hide file tree

Showing 5 changed files with 14 additions and 30 deletions.
diff --git a/changelog/26.feature.rst b/changelog/26.feature.rst
@@ -0,0 +1 @@
+Adds a module for ELO Ranking Algorithm.
diff --git a/pythia/cleaning/elo.py b/pythia/cleaning/elo.py
@@ -38,8 +38,8 @@ def __init__(self, score_board: pd.DataFrame, *, k_value=32, default_score=1400,
         column_map : dict, optional
             Dictionary, for mapping the column names of the score_board dataframe
             to variable names used in the ELO ranking system.
-            by default {"player 0": "image_id_0", 
-                                    "player 1": "image_id_1", 
+            by default {"player 0": "image_id_0",
+                                    "player 1": "image_id_1",
                                     "score for player 0": "image0_more_complex_image1"}
         """
         self.score_board = score_board

diff --git a/pythia/cleaning/tests/test_elo.py b/pythia/cleaning/tests/test_elo.py
@@ -18,7 +18,7 @@ def elo():
     column_map = {"player 0": "image_id_0",
                   "player 1": "image_id_1",
                   "score for player 0": "image0_more_complex_image1"}
- 
+
     return ELO(score_board=sunspotter.classifications, column_map=column_map)
 
 
@@ -33,16 +33,16 @@ def test_expected_score(elo, rating_0, rating_1, expected_score):
 
 
 @pytest.mark.parametrize('rating_for_image,k_value,score_for_image,image_expected_score,new_rating',
-                          [(1400.0, 32, 1, 0.5, 1416.0),
-                           (1450.0, 32, 0, 0.49928044265518673, 1434.023025835034),
-                           (1500.0, 32, 0, 0.3572869311673796, 1488.5668182026438),
-                           (1550.0, 32, 1, 0.14768898365874825, 1577.2739525229201),
-                           (1600.0, 32, 1, 0.029314241270450396, 1631.0619442793457),
-                           (1400.0, 32, 0, 0.5, 1384.0),
-                           (1450.5, 32, 1, 0.5007195573448133, 1466.476974164966),
-                           (1602.0, 32, 1, 0.6427130688326204, 1613.4331817973562),
-                           (1854.5, 32, 0, 0.8523110163412517, 1827.2260474770799),
-                           (2208.0, 32, 0, 0.9706857587295497, 2176.9380557206546)])
+                         [(1400.0, 32, 1, 0.5, 1416.0),
+                          (1450.0, 32, 0, 0.49928044265518673, 1434.023025835034),
+                          (1500.0, 32, 0, 0.3572869311673796, 1488.5668182026438),
+                          (1550.0, 32, 1, 0.14768898365874825, 1577.2739525229201),
+                          (1600.0, 32, 1, 0.029314241270450396, 1631.0619442793457),
+                          (1400.0, 32, 0, 0.5, 1384.0),
+                          (1450.5, 32, 1, 0.5007195573448133, 1466.476974164966),
+                          (1602.0, 32, 1, 0.6427130688326204, 1613.4331817973562),
+                          (1854.5, 32, 0, 0.8523110163412517, 1827.2260474770799),
+                          (2208.0, 32, 0, 0.9706857587295497, 2176.9380557206546)])
 def test_new_rating(elo, rating_for_image, k_value, score_for_image, image_expected_score, new_rating):
     assert elo.new_rating(rating_for_image, k_value, score_for_image, image_expected_score) == new_rating
 

diff --git a/pythia/seo/tests/test_classifications.csv b/pythia/seo/tests/test_classifications.csv
diff --git a/pythia/seo/tests/test_rankings.csv b/pythia/seo/tests/test_rankings.csv