Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arming Module #61

Merged
merged 6 commits into from
Sep 6, 2024
Merged

Conversation

AsiiaPine
Copy link
Collaborator

@AsiiaPine AsiiaPine commented Sep 2, 2024

  1. The PR implements the Arming module which manages the stats.engaged_time parameter. It checks mode of the node and setup the number of seconds the node was ENGAGED.
  2. The node's Mode was extended up to 4 states STANDBY, ENGAGED, INITIALIZATION, MAINTENANCE, mode assign for active components was updated relatively with the ENGAGED mode logic.
  3. Upd libparams, add definitions for sitl storage files to Cmake.
  4. Upd Dronecan to version with ArmingStatus msg.
  5. Fix bug with ADC driver for sitl (5v channel given 0v).

Firmware image size difference

  • dronecan_v2: 40796 -> 41164 (+368)
  • dronecan_v3: 49916 -> 50340 (+424)
  • cyphal_v2: 43480 -> 43652 (+172)
  • cyphal_v3: 54708 -> 54908 (+200)

Test coverage

Screencast.from.09-02-2024.04.02.44.PM.webm
  • In SITL
  • With real device...

@AsiiaPine AsiiaPine marked this pull request as ready for review September 2, 2024 13:48
Copy link
Contributor

@PonomarevDA PonomarevDA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, fix the dronecan and cyphal modes. When the node is engaged, it shouldn't be in initialization mode as shown in your video. Since you have extended Module::Mode and it doesn't correspond to cyphal and dronecan modes anymore, you should manually convert from Module::Mode to cyphal and dronecan modes.

Src/modules/dronecan/arming/arming.hpp Outdated Show resolved Hide resolved
Src/modules/dronecan/arming/arming.cpp Outdated Show resolved Hide resolved
Libs/Cyphal Outdated Show resolved Hide resolved
Src/modules/dronecan/arming/arming.cpp Show resolved Hide resolved
Src/modules/imu/imu.cpp Outdated Show resolved Hide resolved
Src/modules/imu/CMakeLists.txt Outdated Show resolved Hide resolved
Copy link

sonarqubecloud bot commented Sep 5, 2024

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@PonomarevDA PonomarevDA merged commit ddab6d7 into RaccoonlabDev:main Sep 6, 2024
8 checks passed
@PonomarevDA PonomarevDA added the enhancement New feature or request label Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants