Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix circuit_id type from uint8_t to uint16_t #91

Merged
merged 2 commits into from
Dec 4, 2024
Merged

Fix circuit_id type from uint8_t to uint16_t #91

merged 2 commits into from
Dec 4, 2024

Conversation

olegogogo
Copy link
Contributor

This PR fixes circuit_id type from uint8_t to uint16_t

Test coverage

  • With real device:

circuit_id before

изображение

circuit_id after

изображение

@olegogogo
Copy link
Contributor Author

olegogogo commented Dec 4, 2024 •
edited
Loading

Relates to #85

@PonomarevDA PonomarevDA requested a review from AsiiaPine December 4, 2024 08:16
@PonomarevDA PonomarevDA added the bug Something isn't working label Dec 4, 2024
@AsiiaPine
Copy link
Collaborator

Change node_id parameter restriction from (min 0, max 255) to (min 1, max 126) in src/modules/system/params.yaml, please)

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Dec 4, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@olegogogo
Copy link
Contributor Author

Change node_id parameter restriction from (min 0, max 255) to (min 1, max 126) in src/modules/system/params.yaml, please)

now it's restricted)
изображение

AsiiaPine
AsiiaPine approved these changes Dec 4, 2024
View reviewed changes
Copy link
Collaborator

@AsiiaPine AsiiaPine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All is great, Thanks!

@PonomarevDA PonomarevDA merged commit 1285236 into RaccoonlabDev:main Dec 4, 2024
8 checks passed
@PonomarevDA PonomarevDA linked an issue Dec 4, 2024 that may be closed by this pull request
circuit_id value bug #85
Closed
@PonomarevDA
Copy link
Contributor

Good. Thank you.

@PonomarevDA PonomarevDA mentioned this pull request Dec 4, 2024
Closed
@olegogogo olegogogo deleted the CircuitStatus-uint16-fix branch December 5, 2024 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AsiiaPine AsiiaPine AsiiaPine approved these changes

@PonomarevDA PonomarevDA PonomarevDA approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

circuit_id value bug
3 participants
@olegogogo @AsiiaPine @PonomarevDA