V 0.4.0 (#11)

Upgrade to support FoundryVtt version 11 Bugfix for the bonus/malus dice
RackNarDev · Feb 22, 2024 · 8a9b78b · 8a9b78b
1 parent 665e307
commit 8a9b78b
Show file tree

Hide file tree

Showing 6 changed files with 33 additions and 8 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,17 @@
 # Change Log
 
+## [0.4.0] - 2024-02-22
+
+### Added
+
+### Changed
+
+- Upgrade to support FoundryVtt version 11
+
+### Fixed
+
+- Bug with the bonus/malus dice in the dice roller popup
+
 ## [0.3.0] - 2023-02-09
 
 ### Added

diff --git a/supers/lang/de.json b/supers/lang/de.json
@@ -84,6 +84,7 @@
     "fromTempCompetency": "temporäre Kompetenzwürfel",
     "max": "max",
     "name": "name",
-    "none": "keine"
+    "none": "keine",
+    "RollAtLeastOneDie":  "Würfle mindestens einen Würfel"
   }
 }
diff --git a/supers/lang/en.json b/supers/lang/en.json
@@ -92,6 +92,7 @@
     "name": "name",
     "none": "none",
     "remove": "remove",
-    "uncounted": "uncounted"
+    "uncounted": "uncounted",
+    "RollAtLeastOneDie": "Roll at least one die"
   }
 }
diff --git a/supers/system.json b/supers/system.json
@@ -8,9 +8,9 @@
     }
   ],
   "compatibility": {
-    "maximum": 10,
-    "minimum": 9,
-    "verified": "10.291"
+    "maximum": 11,
+    "minimum": 11,
+    "verified": "11.315"
   },
   "description": "Supers!",
   "download": "https://github.com/RackNarDev/supers-rpg-foundryvtt/releases/latest/download/supers.zip",
@@ -77,5 +77,5 @@
   "templateVersion": 2,
   "title": "Supers!",
   "url": "https://github.com/RackNarDev/supers-rpg-foundryvtt",
-  "version": "0.3.0"
+  "version": "0.4.0"
 }
diff --git a/supers/system/rollDialog.js b/supers/system/rollDialog.js
@@ -1,4 +1,4 @@
-import {parseToPositiveNumber} from './validate.js';
+import {parseToPositiveNumber, parseToPositiveOrNegativeNumber} from './validate.js';
 
 const template = 'systems/supers/dialogs/dice-roll.hbs';
 
@@ -19,10 +19,16 @@ export const rollDialog = async (actor, options, onSuccess) => {
           const tempCompetencyDice = parseToPositiveNumber(html.find('#s_dd_temp-cd').val());
           const actorCompetencyDice = parseToPositiveNumber(html.find('#s_dd-a-cd').val());
           const otherPoolCompetencyDice = parseToPositiveNumber(html.find('#s_dd_op-cd').val());
-          const bonusDice = parseToPositiveNumber(html.find('#s_dd_bd').val());
+          const bonusDice = parseToPositiveOrNegativeNumber(html.find('#s_dd_bd').val());
 
           options.diceAmount = options.diceAmount
               + tempCompetencyDice + actorCompetencyDice + otherPoolCompetencyDice + bonusDice;
+
+          if (options.diceAmount < 1) {
+            ui.notifications.error(game.i18n.format('SUPERS.RollAtLeastOneDie'));
+            return;
+          }
+
           options.modifierDice = {tempCompetencyDice, actorCompetencyDice, otherPoolCompetencyDice, bonusDice};
 
           if (actor.system.Competency) {

diff --git a/supers/system/validate.js b/supers/system/validate.js
@@ -3,3 +3,8 @@ export const parseToPositiveNumber = v => {
   let t= Math.abs(parseInt(v));
   return isNaN(t) ? 0 : t;
 }
+
+export const parseToPositiveOrNegativeNumber = v => {
+  let t= parseInt(v);
+  return isNaN(t) ? 0 : t;
+}