Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read fhd catalog fix #207

Merged
merged 6 commits into from
Feb 10, 2024
Merged

Read fhd catalog fix #207

merged 6 commits into from
Feb 10, 2024

Conversation

dstorer
Copy link
Contributor

@dstorer dstorer commented Jun 13, 2023

Minor fix to allow SkyModel to read fhd catalogs with the naming convention source_array - previously, the only acceptable name was catalog.

Description

Check for catalog file name before reading and read appropriate name.

Motivation and Context

Change allows us to read all types of fhd output catalogs.

Checklists:

Bug Fix Checklist:

  • I have read the contribution guide.
  • My code follows the code style of this project.
  • My fix includes a new test that breaks as a result of the bug (if possible).
  • My change includes a breaking change
    • My change includes backwards compatibility and deprecation warnings (if possible).
  • I have updated the CHANGELOG.

@dstorer dstorer requested a review from bhazelton June 13, 2023 18:42
@codecov
Copy link

codecov bot commented Jun 13, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f3f91ce) 100.00% compared to head (b8e373e) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #207   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            5         5           
  Lines         2129      2134    +5     
  Branches       606       608    +2     
=========================================
+ Hits          2129      2134    +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bhazelton bhazelton added the bug Something isn't working label Jun 13, 2023
Copy link
Member

@bhazelton bhazelton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good, there's just one line that's not covered by tests. I just merged a PR that will fix the pre-commit and tutorial test errors, so if you rebase this on main I think those issues will go away.

@dstorer dstorer force-pushed the read_fhd_catalog_fix branch from 7aed6ae to 884b2f5 Compare June 14, 2023 21:17
@bhazelton bhazelton force-pushed the read_fhd_catalog_fix branch 2 times, most recently from e0ea8ae to ef6a407 Compare December 14, 2023 16:08
@bhazelton bhazelton force-pushed the read_fhd_catalog_fix branch from ef6a407 to 4e5955d Compare February 9, 2024 23:05
@bhazelton bhazelton force-pushed the read_fhd_catalog_fix branch from 700a946 to f2cc19d Compare February 9, 2024 23:10
@bhazelton bhazelton force-pushed the read_fhd_catalog_fix branch from 2293303 to 4a641e9 Compare February 9, 2024 23:28
Copy link
Member

@bhazelton bhazelton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dstorer!

@bhazelton bhazelton merged commit 8921223 into main Feb 10, 2024
40 checks passed
@bhazelton bhazelton deleted the read_fhd_catalog_fix branch February 10, 2024 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants