-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Read fhd catalog fix #207
Read fhd catalog fix #207
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #207 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 5 5
Lines 2129 2134 +5
Branches 606 608 +2
=========================================
+ Hits 2129 2134 +5 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking good, there's just one line that's not covered by tests. I just merged a PR that will fix the pre-commit and tutorial test errors, so if you rebase this on main I think those issues will go away.
7aed6ae
to
884b2f5
Compare
e0ea8ae
to
ef6a407
Compare
ef6a407
to
4e5955d
Compare
Improve error message, update changelog
700a946
to
f2cc19d
Compare
2293303
to
4a641e9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @dstorer!
Minor fix to allow SkyModel to read fhd catalogs with the naming convention
source_array
- previously, the only acceptable name wascatalog
.Description
Check for catalog file name before reading and read appropriate name.
Motivation and Context
Change allows us to read all types of fhd output catalogs.
Checklists:
Bug Fix Checklist: