Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix the units on FHD reference frequencies #224

Merged
merged 1 commit into from
Jan 4, 2024
Merged

Conversation

bhazelton
Copy link
Member

Description

The units on FHD catalogs are always in MHz but were being read in as if they were in Hz. This fixes that.

Motivation and Context

fixes #213

Checklists:

Bug Fix Checklist:

  • I have read the contribution guide.
  • My code follows the code style of this project.
  • My fix includes a new test that breaks as a result of the bug (if possible).
  • My change includes a breaking change
    • My change includes backwards compatibility and deprecation warnings (if possible).
  • I have updated the CHANGELOG.

@bhazelton bhazelton added the bug Something isn't working label Dec 21, 2023
Copy link

codecov bot commented Dec 21, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3620163) 100.00% compared to head (eb2c730) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #224   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            5         5           
  Lines         2115      2115           
  Branches       600       600           
=========================================
  Hits          2115      2115           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@nicelmh nicelmh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@bhazelton bhazelton merged commit b7c46e2 into main Jan 4, 2024
40 checks passed
@bhazelton bhazelton deleted the fix_fhd_units branch January 4, 2024 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FHD catalogs are read in with wrong frequency units
2 participants