Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

generalizing jones matrix for Nfeeds=1,2 #394

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

generalizing jones matrix for Nfeeds=1,2 #394

wants to merge 2 commits into from

Conversation

slosar
Copy link
Contributor

@slosar slosar commented Mar 30, 2022

Changes the jones matrix routine to (Nfeeds,2) instead of (2,2) generalizing to any Nfeeds. Down the line Nfeeds can still be only 1 or 2, but this can be changed. This is only a proposal.

Description

See file changes - pretty obvious. Still specialized for theta-phi coordinate system.

NEEDS TESTS!

@codecov
Copy link

codecov bot commented Mar 30, 2022

Codecov Report

Attention: Patch coverage is 90.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 99.95%. Comparing base (c93c507) to head (b8863ac).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/pyuvsim/uvsim.py 83.33% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##              main     #394      +/-   ##
===========================================
- Coverage   100.00%   99.95%   -0.05%     
===========================================
  Files           10       10              
  Lines         2025     2029       +4     
===========================================
+ Hits          2025     2028       +3     
- Misses           0        1       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants