Skip to content

Commit

Permalink
Tweaks Gemfile/gemspec for new offenses
Browse files Browse the repository at this point in the history
Rubocop now prefers add_dependency over add_runtime_dependency
as the latter is considered soft-deprecated.

It also wanted us to move the development dependencies to the Gemfile.

Co-authored-by: Alex Stone <[email protected]>
Co-authored-by: James Nebeker <[email protected]>
Co-authored-by: JC Avena <[email protected]>
Co-authored-by: Jaxon Avena <[email protected]>
  • Loading branch information
5 people committed Nov 6, 2024
1 parent 8f0629d commit ff678da
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 6 deletions.
5 changes: 5 additions & 0 deletions Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,11 @@ git_source(:github) { |repo_name| "https://github.com/#{repo_name}" }
# Specify your gem's dependencies in radius-spec.gemspec
gemspec

group :development do
gem "bundler", ">= 2.2.10"
gem "rake", ">= 12.0", "< 14.0"
end

group :benchmark, optional: true do
gem 'activesupport', require: false
gem 'benchmark-ips', require: false
Expand Down
9 changes: 3 additions & 6 deletions radius-spec.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -31,10 +31,7 @@ Gem::Specification.new do |spec|

spec.required_ruby_version = ">= 3.1" # rubocop:disable Gemspec/RequiredRubyVersion

spec.add_runtime_dependency "rspec", "~> 3.7"
spec.add_runtime_dependency "rubocop", ">= 1.25", "< 1.65"
spec.add_runtime_dependency "rubocop-rails", ">= 2.13", "< 2.22"

spec.add_development_dependency "bundler", ">= 2.2.10"
spec.add_development_dependency "rake", ">= 12.0", "< 14.0"
spec.add_dependency "rspec", "~> 3.7"
spec.add_dependency "rubocop", ">= 1.25", "< 1.65"
spec.add_dependency "rubocop-rails", ">= 2.13", "< 2.22"
end

0 comments on commit ff678da

Please sign in to comment.