Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rubocop-rails requirement from >= 2.13, < 2.20 to >= 2.13, < 2.21 #62

Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jun 19, 2023

Updates the requirements on rubocop-rails to permit the latest version.

Release notes

Sourced from rubocop-rails's releases.

RuboCop Rails 2.14.2

Bug fixes

  • #660: Fix a false positive for Rails/MigrationClassName when defining another class. (@​koic)
  • #664: Fix a false positive for Rails/MigrationClassName when ActiveSupport::Inflector is applied to the class name and the case is different. (@​koic)
  • #658: Fix a false positive for Rails/TransactionExitStatement when break is used in loop in transactions. (@​koic)
  • #666: Fix an error for Rails/TransactionExitStatement when transaction block is empty. (@​koic)
  • #673: Fix a false negative for Rails/TransactionExitStatement when return or throw is used in a block in transactions. (@​Tietew)
  • #669: Fix a false positive for Rails/TransactionExitStatement when return is used in rescue. (@​koic)
Changelog

Sourced from rubocop-rails's changelog.

2.14.2 (2022-03-18)

Bug fixes

  • #660: Fix a false positive for Rails/MigrationClassName when defining another class. ([@​koic][])
  • #664: Fix a false positive for Rails/MigrationClassName when ActiveSupport::Inflector is applied to the class name and the case is different. ([@​koic][])
  • #658: Fix a false positive for Rails/TransactionExitStatement when break is used in loop in transactions. ([@​koic][])
  • #666: Fix an error for Rails/TransactionExitStatement when transaction block is empty. ([@​koic][])
  • #673: Fix a false negative for Rails/TransactionExitStatement when return or throw is used in a block in transactions. ([@​Tietew][])
  • #669: Fix a false positive for Rails/TransactionExitStatement when return is used in rescue. ([@​koic][])

2.14.1 (2022-03-16)

Bug fixes

  • #656: Ignore gem name in paths for Rails/MigrationClassName. ([@​sunny][])
  • #657: Only consider migration classes for Rails/MigrationClassName. ([@​sunny][])

2.14.0 (2022-03-15)

New features

Bug fixes

  • #636: Fix a false positive for Rails/ContentTag when using tag method in config/puma.rb. ([@​koic][])
  • #635: Handle t.remove with multiple columns in Rails/BulkChangeTable. ([@​eugeneius][])

Changes

  • #646: Exclude db/schema.rb and db/[CONFIGURATION_NAMESPACE]_schema.rb by default. ([@​koic][])
  • #650: Make Rails/CompactBlank aware of delete_if(&:blank). ([@​koic][])
  • #631: Update Rails/Pluck to be aware of numblocks. ([@​sammiya][])

2.13.2 (2022-01-15)

New features

Bug fixes

... (truncated)

Commits
  • c07599f Cut 2.14.2
  • 8758581 Update Changelog
  • 10e478f Merge pull request #674 from koic/fix_false_positive_for_rails_transaction_ex...
  • d9ec02d [Fix #669] Fix a false positive for Rails/TransactionExitStatement
  • d331c8d Merge pull request #673 from Tietew/fix_a_false_negative_for_rails_transactio...
  • 7327f97 Fix failse negatives for Rails/TransactionExitStatement
  • 7f709e2 Merge pull request #666 from koic/fix_an_error_for_rails_transaction_exit_sta...
  • 36d4524 Fix an error for Rails/TransactionExitStatement
  • b909f24 Merge pull request #665 from koic/fix_a_false_positive_for_rails_migration_cl...
  • b0f4bfd Merge pull request #663 from koic/fix_a_false_positive_for_rails_migration_cl...
  • Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Jun 19, 2023
@jnebeker
Copy link
Contributor

@dependabot rebase

@dependabot dependabot bot force-pushed the dependabot/bundler/rubocop-rails-gte-2.13-and-lt-2.21 branch from 3dad300 to 10005c1 Compare June 22, 2023 15:39
@jnebeker
Copy link
Contributor

Support for Ruby 2.6 is dropped in rubocop-rails version 2.20.0: https://github.com/rubocop/rubocop-rails/blob/master/CHANGELOG.md#changes

Before merging this we should update the CI workflow to no longer run for Ruby 2.6.

@jcavena
Copy link
Contributor

jcavena commented Jun 28, 2023

@dependabot rebase

Updates the requirements on [rubocop-rails](https://github.com/rubocop/rubocop-rails) to permit the latest version.
- [Release notes](https://github.com/rubocop/rubocop-rails/releases)
- [Changelog](https://github.com/rubocop/rubocop-rails/blob/master/CHANGELOG.md)
- [Commits](rubocop/rubocop-rails@v2.13.0...v2.14.2)

---
updated-dependencies:
- dependency-name: rubocop-rails
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/bundler/rubocop-rails-gte-2.13-and-lt-2.21 branch from 10005c1 to 8f06366 Compare June 28, 2023 15:22
@jcavena
Copy link
Contributor

jcavena commented Jun 28, 2023

@dependabot merge

@dependabot dependabot bot merged commit 5083b82 into main Jun 28, 2023
@dependabot dependabot bot deleted the dependabot/bundler/rubocop-rails-gte-2.13-and-lt-2.21 branch June 28, 2023 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants