Decode feature flags for protonvpn s
#368
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcel-engelke
force-pushed
the
367-protonvpn-s
branch
from
6da664e to
d5b8465
Compare
|
@Rafficer ping for attention |
zPhoeniqz
approved these changes
Jul 19, 2024
zPhoeniqz
suggested changes
Dec 9, 2024
There was a problem hiding this comment.
From the ProtonVPN API code:
SECURE_CORE = 1 << 0 # 1
TOR = 1 << 1 # 2
P2P = 1 << 2 # 4
STREAMING = 1 << 3 # 8
IPV6 = 1 << 4 # 16IPv6 needs to be added as well.
Add IPv6 to server features
|
Thanks @zPhoeniqz, I have added your commit to this MR |
guyboertje
reviewed
Jan 22, 2025
protonvpn_cli/utils.py
Outdated
| @@ -115,11 +115,13 @@ def get_servers(): | |||
| # Sort server IDs by Tier | |||
| return [server for server in servers if server["Tier"] <= user_tier and server["Status"] == 1] # noqa | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
@marcel-engelke Are these extra linefeeds necessary?
guyboertje
reviewed
Jan 22, 2025
| for bit_flag in features: | ||
| if (feat & bit_flag) != 0: | ||
| servers_features.append(features[bit_flag]) | ||
| server_features = get_server_features(servername, servers) |
There was a problem hiding this comment.
@marcel-engelke Is this variable rename necessary? It forces 3 other changes that are not code fixes per se. (maybe these little 'extras' are blocking a good review and merge?)
|
@marcel-engelke if you wish to resolve my comments made in-line then I think that this patch LGTM. @Rafficer do you agree? It is about time this was fixed and merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the problem described in #367 while also refactoring the change of #337 into a common decoding function.
Closes #367