Add WSL to CI workflow (#418)

Co-authored-by: Maarten Sijm <[email protected]>

.github/workflows/ci.yaml

@@ -18,3 +18,37 @@ jobs:
       - uses: actions/checkout@v4
       - run: bash test/yaml/generators/test_schemata.sh
       - run: pytest
+
+  test-wsl:
+    runs-on: windows-latest
+    steps:
+      - run: |
+          git config --global core.autocrlf false
+          git config --global core.eol lf
+      - uses: actions/checkout@v4
+      - uses: Vampire/setup-wsl@v4
+        with:
+            distribution: Ubuntu-24.04
+            wsl-version: 2
+            additional-packages:
+                python3
+                python3-yaml
+                python3-colorama
+                python3-argcomplete
+                python3-ruamel.yaml
+                python3-matplotlib
+                python3-requests
+                python3-pytest
+                build-essential
+                default-jre
+                default-jdk
+                kotlin
+                texlive
+                texlive-latex-base
+                texlive-latex-recommended
+                texlive-latex-extra
+                lmodern
+                texlive-science
+                latexmk
+      - shell: wsl-bash {0}
+        run: pytest

bin/util.py

@@ -45,11 +45,6 @@ def is_windows() -> bool:
     return sys.platform in ['win32', 'cygwin']
 
 
-# https://www.scivision.dev/python-detect-wsl/
-def is_wsl() -> bool:
-    return 'Microsoft' in platform.uname().release
-
-
 def is_mac() -> bool:
     return sys.platform in ['darwin']
 
@@ -1044,7 +1039,7 @@ def exec_command(
         kwargs.pop('memory')
     if config.args.memory:
         memory_limit = config.args.memory
-    if is_windows() or is_wsl() or config.args.sanitizer:
+    if is_windows() or config.args.sanitizer:
         memory = None
 
     process: Optional[ResourcePopen] = None
@@ -1062,7 +1057,7 @@ def interrupt_handler(sig, frame):
     tstart = time.monotonic()
 
     try:
-        if not is_windows() and not is_wsl() and preexec_fn:
+        if not is_windows() and preexec_fn:
             process = ResourcePopen(
                 command,
                 preexec_fn=limit_setter(command, timeout, memory),

readme.md

@@ -54,23 +54,25 @@ After cloning the repository, symlink [bin/tools.py](bin/tools.py) to somewhere
 ```
 
 ### Windows
+For Windows, the preferred way to use BAPCtools is inside the Windows Subsystem for Linux (WSL).
 
-For Windows, you'll need the following in your
-`path`:
-
-- `Python` for Python 3
-- `g++` to compile C++
-- `javac` and `java` to compile and run `java`.
-
-Resource limits (memory limit/hard cpu time limit) are also not supported.
-
-BAPCtools makes use of symlinks for building programs. By default users are not allowed to create symlinks on Windows.
-This can be fixed by enabling Developer Mode on Windows (Only since Windows 10, version 1703 or newer).<br>
+Note that BAPCtools makes use of symlinks for building programs.
+By default, users are not allowed to create symlinks on Windows.
+This can be fixed by enabling Developer Mode on Windows (only since Windows 10 version 1703, or newer).<br>
 In case you're still having problems with symlinks in combination with Git after enabling this setting,
 please try the suggestions at https://stackoverflow.com/a/59761201.
 Specifically, `git config -g core.symlinks true` should do the trick,
 after which you can restore broken symlinks using `git checkout -- path/to/symlink`.
 
+### Native Windows
+If you cannot or do not want to use WSL, you'll need the following in your `%PATH%`:
+
+- `python` for Python 3
+- `g++` to compile C++
+- `javac` and `java` to compile and run Java.
+
+Resource limits (memory limit/hard cpu time limit) are not supported.
+
 ### Docker
 
 A docker image containing this git repo and dependencies, together with commonly

test/problems/hellounix/problem.yaml

@@ -23,3 +23,5 @@ validation: default
 #     time_multiplier: 2
 # Warning for submissions within 1 second of limit:
 #     time_safety_margin: 1
+limits:
+  memory: 512

test/problems/hellounix/submissions/run_time_error/test-memsize_512.cc

@@ -0,0 +1,21 @@
+/*
+ * This should fail with RUN-ERROR due to running out of memory, which
+ * is restricted.
+ *
+ * Note: This may try to create a coredump on exit and time out. This
+ * can be prevented with `ulimit -c 0`.
+ */
+
+#include <iostream>
+#include <vector>
+
+using namespace std;
+
+const size_t mb = 513;
+
+int main() {
+	std::cerr << "Trying to allocate at least: " << 513 << " MB" << std::endl;
+	vector<char> v(513 * 1024 * 1024);
+	std::cerr << "Allocated: " << v.size() << " MB" << std::endl;
+	return 0;
+}