-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#385 Add limits #415
#385 Add limits #415
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Haven't tested it yet, but here are some first comments based on the code 😄
No time to look at the code yet, but I could imagine the |
but should the yaml key override it or be an additional limit (i.e. we take the min of both) and should that be for submissions or all subprocesses... ? |
I think everything should work now, @mpsijm do you have time to give it a try? :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've used your branch today when preparing some problem ideas for the Freshmen Programming Contests, and it didn't crash 😄 I used at least bt run
, bt generate
, bt validate
, bt constraints
, and bt fuzz
. Note that I haven't actually touched any of the new limits yet, nor did I explicitly try to push a submission/generator/validator past the time/memory/output limit (I only had some TLE submissions). But some testing is better than no testing, I guess 😛
Co-authored-by: Maarten Sijm <[email protected]>
implement some more limits.
Fixes #385