Fix an oversight in the water types analysis script #383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The file list should contain both RSW and GND maps, but unpacking tables with duplicate indices doesn't work the same way in Lua as it does in JavaScript. The end result is that only the GND maps are collected as the previously unpacked keys are overwritten.
rdw-software
force-pushed
the
fix-water-analysis
branch
from
3341a73
to
3e6175a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The file list should contain both RSW and GND maps, but unpacking tables with duplicate indices doesn't work the same way in Lua as it does in JavaScript. The end result is that only the GND maps are collected as the previously unpacked keys are overwritten.