Skip to content

Rounding out ATtiny 14-pin 0-series with 204/804/1604 support #182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 3, 2025

Conversation

nonik0
Copy link
Contributor

@nonik0 nonik0 commented Mar 15, 2025

Adding support for the rest of ATtiny 14 pin 0-series , ATtiny202, ATtiny804, and Attiny1604. Verified basic functionality with attiny1614 with no issues so far. I was halfway working through this PR when noticed #181, so would like to acknowledge @Phil-hacker's work as well.

I have support in avr-hal in progress as well: https://github.com/nonik0/avr-hal/tree/attiny204-804-1604

Need a bit a clarification on the guidance around maintaining the alphabetical sorting of the chips. I was getting confused and just asked an LLM to do it and it ended up reordering a lot more than I expected. So it seems like the ordering is inconsistent in various locations.

@Rahix
Copy link
Owner

Rahix commented Apr 16, 2025

Hi, thanks a lot for your contribution and sorry for the late reply! Just a heads-up, I am holding off merging new chips right now until #157 is merged, which quite significantly changes the way the register definitions are generated. I will ping you once this change has landed so you can rebase your changes ontop of it.


Need a bit a clarification on the guidance around maintaining the alphabetical sorting of the chips.

Yeah, there is no logic to it, unfortunately many people didn't place their chips in the right section which I then didn't want to fix to not cause unnecessary rebase work for others... But I think the aforementioned #157 cleans up that mess to some degree as well.

@Rahix
Copy link
Owner

Rahix commented Apr 18, 2025

Here's the notification: #157 was merged 🎉 Please rebase your work ontop of the new code-generation. You should be able to make out the new structure in src/devices/mod.rs from the way things look for the existing chips. The Makefile is dropped completely.

Copy link
Owner

@Rahix Rahix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@Rahix Rahix merged commit 56bb1b5 into Rahix:main May 3, 2025
2 checks passed
@Rahix Rahix mentioned this pull request May 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants