feat: refactor kafka source API and enhance virtual sources resolving logic #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
gabb1er
commented
Apr 16, 2024
gabb1er
commented
- added support for binary format for key and value. This means, that kafka message key or value is read as is, without casting to other types. Thus, it is up to user to use virtual sources/streams functionality to cast column to a desired type suitable for data quality checks.
- added boolean flag to enable schema ID subtraction from kafka value: when schema registry is used, the schema ID is embedded into kafka value (magic byte + 4 bytes of schema ID). Therefore, in order to parse value, first it is required to subtract schema ID from it.
- changed Avro schema API by adding boolean flag that enables or disable default values checks.
- refactor logic for resolving virtual sources: now they are resolved not in order but rather with respect to their parents dependencies.
- added tests to verify virtual source resolving logic.
- documentation updated with respect to API changes.
- configuration api version is updated to 1.5
- fixes:
- updates SQLIte dependency version: security patch [VDB-248999].
- fixed JoinVirtualSourceReader by adding aliases to dataframes that are being joined. This is needed to avoid ambiguous column referencing in the resultant dataframe.
… logic:
- added support for binary format for key and value. This means, that kafka message key or value is read as is, without casting to other types. Thus, it is up to user to use virtual sources/streams functionality to cast column to a desired type suitable for data quality checks.
- added boolean flag to enable schema ID subtraction from kafka value: when schema registry is used, the schema ID is embedded into kafka value (magic byte + 4 bytes of schema ID). Therefore, in order to parse value, first it is required to subtract schema ID from it.
- changed Avro schema API by adding boolean flag that enables or disable default values checks.
- refactor logic for resolving virtual sources: now they are resolved not in order but rather with respect to their parents dependencies.
- added tests to verify virtual source resolving logic.
- documentation updated with respect to API changes.
- configuration api version is updated to 1.5
- fixes:
- updates SQLIte dependency version: security patch [VDB-248999].
- fixed JoinVirtualSourceReader by adding aliases to dataframes that are being joined. This is needed to avoid ambiguous column referencing in the resultant dataframe.
cibaa-team-user
approved these changes
Apr 16, 2024
cibaa-team-user
pushed a commit
that referenced
this pull request
Apr 16, 2024
# [1.6.0](v1.5.0...v1.6.0) (2024-04-16) ### Features * refactor kafka source API and enhance virtual sources resolving logic ([#37](#37)) ([8ea9c23](8ea9c23))
|
🎉 This PR is included in version 1.6.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.