fix: update covariance metric logic #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
gabb1er
commented
May 3, 2024
gabb1er
commented
- (was): if for any row the values in requested columns were not numeric, the final result of covariance metrics would be NaN.
- (now): the rows with non-numeric values are just skipped. Result is NaN only when all rows are skipped or the number of rows is zero (empty dataset).
- fixed merging for covariance metric calculators: avoid division by zero when merging calculators with empty states.
- also fixed json serialization utils for case classes: previous approach yielded field names and values.
- (was): if for any row the values in requested columns were not numeric, the final result of covariance metrics would be NaN. - (now): the rows with non-numeric values are just skipped. Result is NaN only when all rows are skipped or the number of rows is zero (empty dataset). - fixed merging for covariance metric calculators: avoid division by zero when merging calculators with empty states. - also fixed json serialization utils for case classes: previous approach yielded field names and values.
cibaa-team-user
approved these changes
May 3, 2024
cibaa-team-user
pushed a commit
that referenced
this pull request
May 13, 2024
# [1.7.0](v1.6.0...v1.7.0) (2024-05-13) ### Bug Fixes * modify unique key constraint for regular metrics results table ([#38](#38)) ([6a67b2f](6a67b2f)) * update covariance metric logic ([#39](#39)) ([0951ddc](0951ddc)) ### Features * adding schema registry reader and corresponding schema configuration ([#40](#40)) ([be48204](be48204))
|
🎉 This PR is included in version 1.7.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.